Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ki_luria #828

Merged
merged 11 commits into from
Jan 15, 2025
Merged

ki_luria #828

merged 11 commits into from
Jan 15, 2025

Conversation

bumproo
Copy link
Contributor

@bumproo bumproo commented Jan 14, 2025


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@bumproo bumproo requested a review from husensofteng January 14, 2025 16:26
@jfy133
Copy link
Member

jfy133 commented Jan 15, 2025

@bumproo do you still want a review from @husensofteng before merging?

@bumproo
Copy link
Contributor Author

bumproo commented Jan 15, 2025

Hi James,
no, I don't think so on @husensofteng review. I don't 100% know what I'm doing and saw that I should request a review. It was probably my error

@bumproo bumproo merged commit e198e2b into nf-core:master Jan 15, 2025
140 checks passed
@bumproo bumproo deleted the ki_luria branch January 15, 2025 16:40
@bumproo bumproo restored the ki_luria branch January 15, 2025 16:42
@bumproo bumproo deleted the ki_luria branch January 15, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants