Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsc_kul_uhasselt.conf -- Dynamically adjust account based on queue type #822

Merged
merged 22 commits into from
Jan 10, 2025

Conversation

ljwharbers
Copy link
Contributor

You recently added the dedicated nodes as possible partitions. However, since there is only $SLURM_ACCOUNT is used as the --account. Nextflow submissions will fail because the dedicated nodes have different --account requirements.

This PR has changes to dynamically evaluate whether the outcome of the queue variable is one of the dedicated nodes and will give change the --account cluster option based on this. Another option is to have users specify multiple environment variables and call these instead of the hardcoded --account in clusterOptions like I have done now.

Since there are issues with evaluating queue, I repeated the queue definition statement. It's a bit ugly so if you have other suggestions, feel free.

I have only tested this config for the dedicated vs non-dedicated CPU nodes, not for the gpu or the gpu_h100.

@ljwharbers ljwharbers requested a review from Joon-Klaps January 6, 2025 12:32
@ljwharbers ljwharbers changed the title Dynamically adjust --account based on queue type Update vsc_kul_uhasselt.conf -- Dynamically adjust account based on queue type Jan 6, 2025
Copy link
Contributor

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, well spotted!

@Joon-Klaps Joon-Klaps merged commit eb6bb4b into nf-core:master Jan 10, 2025
139 checks passed
@ljwharbers ljwharbers deleted the kul branch January 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants