Revert "Use weighted sampling for recent samples in global builds" #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
deleted the
revert-1161-victorlin/weight-global-recent
branch
|
Continuing conversation in #1161 (comment) and #1141 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts unapproved PR #1161 due to being not a trivial change reducing recent sample from the expected ~4k to undesirably low ~1.2k
Population weighting is nice, but not at the expense of uncompensated severe downsampling.
See #1161 (comment) for explanation.
I don't know whether that's due to a misconfiguration of population weighting or that population weighting requires continuous tweaking as currently implemented to keep numbers as expected. What do you think @victorlin?
We might be able to just workaround by increasing the sample to above ~4k, but that seems risky and not ideal.