Fix broken links [#1133] #1137
Merged
Fix broken links [#1133] #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
genehack
force-pushed
the
fix-broken-links-1133
branch
4 times, most recently
from
77d82f6 to
fba481a
Compare
victorlin
requested changes
Aug 13, 2024
genehack
force-pushed
the
fix-broken-links-1133
branch
4 times, most recently
from
3fd1204 to
c9f7cfa
Compare
Note: this contains 2 URLs in the `linkcheck_ignore` section that need to be fixed; each has an associated FIXME comment linking to a Github issue. I'm ignoring those temporarily so that after this PR is merged, `make linkcheck` will exit without error in this repo, which will unblock activating linkchecking in _all_ the CI doc builds.
…1133] The linkchecker doesn't recognize the text fragment thing as a real anchor, so just exclude that from the full anchor check.
Known-good URL is failing for technical reasons related to how nextstrain.org handles routing datasets without a default. [Slack context](https://bedfordlab.slack.com/archives/C0K3GS3J8/p1723571470133649)
GISAID is returning 301 on `www.gisaid.org` links, so let's respect it and update our URLs. Also correct some URLs to where they ultimately redirect.
* switch `tree` to `blob`, because they 301 that way * swap `master` for `-`, for future-proofing
genehack
force-pushed
the
fix-broken-links-1133
branch
from
c9f7cfa to
5810e0f
Compare
victorlin
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds linkchecking config, fixes almost all the broken links, and temporarily ignores 2 internal URLs where I need further guidance on the correct fix.
Related issue(s)
Closes #1133
#1135
#1136
nextstrain/.github#29