Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Auspice config files #15

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Update Auspice config files #15

merged 1 commit into from
Apr 24, 2024

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Apr 24, 2024

This PR was motivated initially by wanting to include "division" as a geo resolution, but then expanded to:

  1. Make coloring appropriately capitalized (consistent with ncov)
  2. Call it "Admin Division" for clarity
  3. Include "Originating Lab" as filter and make sure to always order as originating lab, then submitting lab.
  4. Order as Region, Country, Division (consistent with ncov)
  5. Drop PMID from colorings. This wasn't in the metadata and wasn't exported as coloring.

This commit was motivated initially by wanting to include "division" as a geo resolution, but then expanded to:

1. Make coloring appropriately capitalized (consistent with ncov)
2. Call it "Admin Division" for clarity
3. Include "Originating Lab" as filter and make to always order as originating lab, then submitting lab.
4. Order as Region, Country, Division (consistent with ncov)
5. Drop PMID from colorings. This wasn't in the metadata and wasn't exported as coloring.
@trvrb trvrb requested a review from lmoncla April 24, 2024 00:09
@trvrb
Copy link
Member Author

trvrb commented Apr 24, 2024

I don't think anything here should be too controversial. I'm going to go ahead and merge.

@trvrb trvrb merged commit 1016980 into master Apr 24, 2024
6 checks passed
@trvrb trvrb deleted the update-auspice-config branch April 24, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant