Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace numeric with named outputs for GATK_HAPLOTYPECALLER #471

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Replace numeric with named outputs for GATK_HAPLOTYPECALLER #471

merged 1 commit into from
Nov 20, 2024

Conversation

adamrtalbot
Copy link
Collaborator

Some previous outputs of GATK_HAPLOTYPECALLER were still integer based instead of named. This PR replaces them.

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit e234e5c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/673e23043ba7800008e120f9
😎 Deploy Preview https://deploy-preview-471--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pinin4fjords
pinin4fjords approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good to me. I've checked the process definitions associated with all of these to verify presence of the emits.

Also did a final grep to check there aren't more affected files.

Sorry for not doing these when I did the naming.

@adamrtalbot adamrtalbot marked this pull request as ready for review November 20, 2024 19:12
@adamrtalbot adamrtalbot merged commit edec19b into master Nov 20, 2024
8 checks passed
@adamrtalbot adamrtalbot deleted the fix_use_haplotype_caller_named_outputs branch November 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @pinin4fjords