-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust paths so that Gitpod (original) mounting points #462
Conversation
…iner mounting points. In the medium term, we should remove paths and that are specific to the original Gitpod implementation.
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Does this work with the parts where users run a container manually? docker run -it -v ./data:/data community.wave.seqera.io/library/gatk4:4.5.0.0--730ee8817e436867 |
Not if it's run from the symlink directory, no, the path is not valid for docker outside docker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Makes the bam file with gitpod paths work as an input at least.
Some examples will be confusing to users due to the mismatch, so we shouldn't leave the proper fix too long.
Will also be a problem here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat
Symlink to required so that paths in the materials that expect the Gitpod (classic) paths still resolve in devcontainers.
In the medium term, we should remove paths and that are specific to the original Gitpod implementation.