Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust paths so that Gitpod (original) mounting points #462

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

robsyme
Copy link
Contributor

@robsyme robsyme commented Nov 18, 2024

Symlink to required so that paths in the materials that expect the Gitpod (classic) paths still resolve in devcontainers.

In the medium term, we should remove paths and that are specific to the original Gitpod implementation.

…iner

mounting points.

In the medium term, we should remove paths and that are specific to the
original Gitpod implementation.
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 9d9d8af
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/673a9d621d7a72000855ee7d
😎 Deploy Preview https://deploy-preview-462--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamrtalbot
Copy link
Collaborator

Does this work with the parts where users run a container manually?

docker run -it -v ./data:/data community.wave.seqera.io/library/gatk4:4.5.0.0--730ee8817e436867

@pinin4fjords
Copy link
Collaborator

Does this work with the parts where users run a container manually?

docker run -it -v ./data:/data community.wave.seqera.io/library/gatk4:4.5.0.0--730ee8817e436867

Not if it's run from the symlink directory, no, the path is not valid for docker outside docker.

Copy link
Collaborator

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Makes the bam file with gitpod paths work as an input at least.

Some examples will be confusing to users due to the mismatch, so we shouldn't leave the proper fix too long.

@pinin4fjords
Copy link
Collaborator

Does this work with the parts where users run a container manually?

docker run -it -v ./data:/data community.wave.seqera.io/library/gatk4:4.5.0.0--730ee8817e436867

Will also be a problem here

Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@pinin4fjords pinin4fjords merged commit a48ea21 into master Nov 18, 2024
8 checks passed
@pinin4fjords pinin4fjords deleted the gitpod-path-workaround branch November 18, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants