Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team mentions #4678

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Team mentions #4678

wants to merge 7 commits into from

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Feb 4, 2025

πŸ–ΌοΈ Screenshots

Before After
mention-team1 mention_with_correct_placeholder

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Team support Team mentions Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Copy link
Contributor

github-actions bot commented Feb 4, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4678-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@@ -838,7 +838,8 @@ class MessageInputFragment : Fragment() {
mentionId.contains("@") ||
mentionId.startsWith("guest/") ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mentionId.startsWith("guest/") ||
mentionId.contains("/")

And simplify your life? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants