Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up fixes for 'Archive Conversations #4624

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Follow up fixes for 'Archive Conversations #4624

merged 4 commits into from
Jan 23, 2025
+156 −41

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 16, 2025 •
edited by mahibi
Loading

🚧 TODO

  • It should be possible to archive from the context menu on the conversation list
  • The option somehow does not look like a option, maybe because other things around it are red and participant list?
  • The option can not be toggled multiple times: After turning it on, you need to leave the details in order to be able to turn if off again. Pressing it a second time without leaving and coming back does not do anything.
  • After filtering for archived conversations and forgetting about it, i was shocked for some seconds why the conversations don't load. Turned out i had the filter enabled but no conv is archived. In this case we should give a hint about it as a text in middle of the screen.
  • the "Unread mentions" bubble is not updated when filtering.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 marked this pull request as ready for review January 17, 2025 18:55
@mahibi
Copy link
Collaborator

mahibi commented Jan 20, 2025

@rapterjet2004 is this ready to review? Not sure as one checkbox is unticked..
Please remember to set and update the PR labels "2. developing" / "3. to review" so i won't review too early

@rapterjet2004 rapterjet2004 added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 21, 2025
@rapterjet2004 rapterjet2004 requested a review from mahibi January 22, 2025 18:01
@mahibi
Copy link
Collaborator

mahibi commented Jan 23, 2025

@rapterjet2004 works fine for me. Just to let you know, i made some changes to the PR:

before/after

before/after

added snackbar for archive/unrachive action from bottomDialog

@mahibi mahibi force-pushed the issue-4607-4608-archive-conversations-follow-up branch from ab8b105 to 589cea9 Compare January 23, 2025 11:06
rapterjet2004 and others added 3 commits January 23, 2025 12:11
@rapterjet2004 @mahibi
Archived conversation improvements
a6055e5 
- First commit - Made options yellow
- Now possible to archive/unarchive conversations from dialog
- Now possible to archive and unarchive conversations in settings without leaving the screen
- Better UX
- Unread message bubble fix - no longer shows up when archive filter is set

Signed-off-by: rapterjet2004 <[email protected]>
@mahibi
change "No conversations archived" screen design
71af112 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
change "Archive conversation" design in conversation-info screen
3427f4c 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the issue-4607-4608-archive-conversations-follow-up branch from 589cea9 to 9f640e7 Compare January 23, 2025 11:13
@mahibi mahibi force-pushed the issue-4607-4608-archive-conversations-follow-up branch from 9f640e7 to 7ac8c24 Compare January 23, 2025 11:24
@mahibi mahibi added this to the 21.0.0 milestone Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4624-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi enabled auto-merge January 23, 2025 12:08
@mahibi mahibi merged commit b3f32a0 into master Jan 23, 2025
18 checks passed
@mahibi mahibi deleted the issue-4607-4608-archive-conversations-follow-up branch January 23, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

Archive conversation follow ups #2 Archive conversation option follow ups
2 participants
@rapterjet2004 @mahibi