Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-20.1] Convert log class to kotlin #4575

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 3, 2025

Backport of PR #4574

mahibi added 2 commits January 3, 2025 12:14
Signed-off-by: Marcel Hibbe <[email protected]>
@JvmStatic is necessary to keep the static behavior of the method calls

Signed-off-by: Marcel Hibbe <[email protected]>
@backportbot backportbot bot requested a review from mahibi January 3, 2025 12:14
@backportbot backportbot bot added the 3. to review Waiting for reviews label Jan 3, 2025
@backportbot backportbot bot added this to the 20.1.1 milestone Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4575-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Codacy

Lint

TypemasterPR
Warnings158158
Errors7171

SpotBugs

CategoryBaseNew
Bad practice66
Correctness22216
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310104

@AndyScherzinger AndyScherzinger merged commit 058db13 into stable-20.1 Jan 3, 2025
15 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/4574/stable-20.1 branch January 3, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants