hide "unread mention" bubble in search mode #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sowjanyakch thanks for your PR, it works as expected 👍 just one minor remark: |
mahibi
reviewed
Nov 2, 2023
app/src/main/java/com/nextcloud/talk/conversationlist/ConversationsListActivity.kt
Show resolved
Hide resolved
AndyScherzinger
added
enhancement
mahibi
force-pushed
the
issue-2464-hide-unread-mention-bubble-in-search
branch
from
69ae749 to
305ec47
Compare
|
Thank you @sowjanyakch , well done 👍 |
|
Nice work @sowjanyakch 🎉 |
sowjanyakch
deleted the
issue-2464-hide-unread-mention-bubble-in-search
branch
mahibi
added a commit
that referenced
this pull request
Sep 9, 2024
bug was introduced with #3417 Signed-off-by: Marcel Hibbe <[email protected]>
sowjanyakch
pushed a commit
that referenced
this pull request
Sep 11, 2024
bug was introduced with #3417 Signed-off-by: Marcel Hibbe <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
bug was introduced with #3417 Signed-off-by: Marcel Hibbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2464
🖼️ Screenshots
This pull request hides the “unread mention” bubble when the search is activated #2464
This pull request uses the BehaviorSubject to monitor the activation state of the search mode. BehaviorSubject emits true (boolean value) when search mode is active and false (boolean value) when search mode is inactive.
UI elements should subscribe to the BehaviorSubject and show or hide the “unread mention” bubble based on search mode activation state. If the BehaviorSubject emits true, the UI hides “unread mention” bubble, whereas when the BehaviorSubject emits false, the ”unread mention” bubble is shown.
🏁 Checklist
/backport to stable-xx.x