Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(PHP): update phpoffice/phpspreadsheet #1561

Merged
merged 1 commit into from
Jan 30, 2025
Merged

deps(PHP): update phpoffice/phpspreadsheet #1561

merged 1 commit into from
Jan 30, 2025

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 28, 2025

No description provided.

@blizzz blizzz added dependencies Pull requests that update a dependency file 3. to review Waiting for reviews labels Jan 28, 2025
@blizzz blizzz requested review from juliusknorr and enjeck January 28, 2025 12:28
enjeck
enjeck reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@enjeck enjeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have an update to composer.json too? That's what composer.lock is generated from?

@juliusknorr
Copy link
Member

juliusknorr commented Jan 30, 2025 •
edited
Loading

We should also check why dependabot is not suggesting that update Never mind just came across #1560

@blizzz
Copy link
Member Author

blizzz commented Jan 30, 2025

Can we update it once manually with this PR, before renovate runs at some point? For, the idea was to have releases this week.

@blizzz blizzz merged commit 7b26b19 into main Jan 30, 2025
54 checks passed
@blizzz blizzz deleted the deps/noid/phpspreadsheet branch January 30, 2025 11:59
@blizzz
Copy link
Member Author

blizzz commented Jan 30, 2025

Also #1562 por favor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjeck enjeck enjeck left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @juliusknorr @enjeck