Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate from vuex to pinia #1540

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: migrate from vuex to pinia #1540

wants to merge 3 commits into from
+676 −483

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jan 13, 2025

fixes #1492

@enjeck enjeck self-assigned this Jan 13, 2025
nfebe
nfebe reviewed Jan 18, 2025
View reviewed changes
Copy link

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

src/main.js Outdated Show resolved Hide resolved
src/main.js Show resolved Hide resolved
@enjeck enjeck force-pushed the pinea branch 2 times, most recently from 54a3d9c to 9b7249a Compare January 20, 2025 08:23
@enjeck enjeck marked this pull request as ready for review January 21, 2025 08:05
@enjeck enjeck requested a review from blizzz as a code owner January 21, 2025 08:05
@enjeck enjeck requested a review from juliusknorr January 21, 2025 08:06
@enjeck
Copy link
Contributor Author

enjeck commented Jan 21, 2025 •
edited
Loading

TODO:

  • fix context navigation display. Doesn't work when I test manually, but we have no automated tests to catch this

enjeck added 2 commits January 22, 2025 02:07
@enjeck
feat: migrate from vuex to pinia
4f43877 
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
@enjeck
fix: properly call store functions
6fb10d3 
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
@enjeck
Copy link
Contributor Author

enjeck commented Jan 22, 2025

TODO:

  • fix context navigation display. Doesn't work when I test manually, but we have no automated tests to catch this

Now fixed. Automated tests being written at #1553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe left review comments

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

At least 1 approving review is required to merge this pull request.

Assignees

@enjeck enjeck

Labels
None yet
Projects
📝 Office team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from vuex to pinia
2 participants
@enjeck @nfebe