Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some ignores #4907

Merged
merged 1 commit into from
May 16, 2017
Merged

Add some ignores #4907

merged 1 commit into from
May 16, 2017

Conversation

MorrisJobke
Copy link
Member

No description provided.

Signed-off-by: Morris Jobke <[email protected]>
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @rullzer and @Xenopathic to be potential reviewers.

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 16, 2017
@MorrisJobke MorrisJobke requested a review from LukasReschke May 16, 2017 15:49
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone May 16, 2017
@LukasReschke LukasReschke merged commit 7d5b1b8 into master May 16, 2017
@LukasReschke LukasReschke deleted the mention-bog branch May 16, 2017 15:53
@nickvergessen
Copy link
Member

Useless since the service ignores the ingorelist since more the 1.5years... facebook employee said they have no intend to fix it.... I would just remove it and recommend people to use the suggested reviews instead?

@MorrisJobke
Copy link
Member Author

Useless since the service ignores the ingorelist since more the 1.5years... facebook employee said they have no intend to fix it.... I would just remove it and recommend people to use the suggested reviews instead?

It actually works. The people who complained where not in the list 🙈

@nickvergessen
Copy link
Member

facebookarchive/mention-bot#178 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants