Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] Update files app state on saveAs #3276

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 6, 2023

Combined backport of #3230 and #3277

@juliusknorr juliusknorr force-pushed the bugfix/stable27/saveas-update branch from baba808 to db77734 Compare November 6, 2023 15:21
@juliusknorr juliusknorr changed the title Update files app state on saveAs [stable27] Update files app state on saveAs Nov 6, 2023
@juliusknorr juliusknorr marked this pull request as ready for review November 6, 2023 15:27
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Nov 6, 2023
Copy link

cypress bot commented Nov 6, 2023

Passing run #706 ↗︎

0 31 0 0 Flakiness 0

Details:

[stable27] Update files app state on saveAs
Project: Richdocuments Commit: 88a36d7bfb
Status: Passed Duration: 03:09 💡
Started: Nov 7, 2023 7:50 AM Ended: Nov 7, 2023 7:54 AM

Review all test suite changes for PR #3276 ↗︎

@juliusknorr juliusknorr force-pushed the bugfix/stable27/saveas-update branch from db77734 to 88a36d7 Compare November 7, 2023 07:47
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes comparing this and the parent PRs and looks sensible to me. Some changes from the parent PRs are not in this backport (namely changes to src/views/Office.vue), but they seem to have landed in stable27 before already.

@juliusknorr juliusknorr merged commit f3ec0de into stable27 Nov 7, 2023
35 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/stable27/saveas-update branch November 7, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants