Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased threshold for translations of iOS apps #718

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

i2h3
Copy link
Contributor

@i2h3 i2h3 commented Jan 23, 2025

As discussed with @tobiasKaminsky, the Nextcloud app and Nextcloud Notes app for iOS should import translations only when they are at least 50 % translated. Based on the imported translations we can easily check which localizations to enable inside the Xcode project.

@i2h3 i2h3 requested a review from tobiasKaminsky January 23, 2025 16:30
@i2h3 i2h3 self-assigned this Jan 23, 2025
@i2h3
Copy link
Contributor Author

i2h3 commented Jan 23, 2025

@tobiasKaminsky I intentionally left out the Talk app because I assumed we cannot decide about things in their project.

@tobiasKaminsky tobiasKaminsky merged commit 9eceffb into master Jan 23, 2025
3 checks passed
@tobiasKaminsky tobiasKaminsky deleted the ios-translation-threshold branch January 23, 2025 21:54
@nickvergessen
Copy link
Member

should Talk follow? #718 (comment)

We already do that "manually", we only activate translations in xcode that are more or less 100% translated

so only if we activate it explicitly, it's used in a build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants