fix(translationtool): Fallback to English plural form #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a project does not use any plurals (only `t` and no `n`), then the po file might also not contain the plural header. In this case we still need a plural form string for our Nextcloud JS output. So to solve this we just fallback to English (it is currently not used and will also be overwritten with the correct string as soon as a plural form is used) Signed-off-by: Ferdinand Thiessen <[email protected]>
come-nc
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a project does not use any plurals (only
tand non), then the po file might also not contain the plural header. In this case we still need a plural form string for our Nextcloud JS output.So to solve this we just fallback to English (it is currently not used and will also be overwritten with the correct string as soon as a plural form is used)