Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.1] fix: close modal after creating conversation #6664

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 27, 2025

Backport of PR #6658

@backportbot backportbot bot requested a review from hamza221 January 27, 2025 15:24
@backportbot backportbot bot requested a review from tcitworld as a code owner January 27, 2025 15:24
@backportbot backportbot bot requested review from st3iny and GretaD January 27, 2025 15:24
@backportbot backportbot bot added 3. to review Waiting for reviews bug labels Jan 27, 2025
@backportbot backportbot bot added this to the v5.1.0 milestone Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 14.54%. Comparing base (1da8da7) to head (ed77f5b).
Report is 3 commits behind head on stable5.1.

Files with missing lines Patch % Lines
src/services/talkService.js 0.00% 1 Missing ⚠️
src/views/EditSidebar.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           stable5.1    #6664      +/-   ##
=============================================
+ Coverage      14.51%   14.54%   +0.02%     
=============================================
  Files            210      210              
  Lines           9835     9820      -15     
  Branches        2303     2298       -5     
=============================================
  Hits            1428     1428              
+ Misses          8080     8065      -15     
  Partials         327      327              
Flag Coverage Δ
javascript 14.54% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD merged commit 1f2fabd into stable5.1 Jan 27, 2025
38 of 39 checks passed
@GretaD GretaD deleted the backport/6658/stable5.1 branch January 27, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant