Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: avoid hotkeys in contenteditable #6639

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

janepie
Copy link
Member

@janepie janepie commented Jan 21, 2025

fixes nextcloud/assistant#16

NcRichContenteditable uses a div for text input so shortkeys defined via vue-shortkey do not get avoided unless they are explicitly excluded

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.97%. Comparing base (354109b) to head (cad954e).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
src/main.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6639   +/-   ##
=========================================
  Coverage     22.97%   22.97%           
  Complexity      475      475           
=========================================
  Files           252      252           
  Lines         12128    12128           
  Branches       2317     2317           
=========================================
  Hits           2786     2786           
  Misses         9015     9015           
  Partials        327      327           
Flag Coverage Δ
javascript 14.51% <0.00%> (ø)
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janepie janepie force-pushed the fix/avoid-shortkeys-in-contenteditable branch from 91680d5 to cad954e Compare January 21, 2025 09:09
@GretaD GretaD added the 3. to review Waiting for reviews label Jan 21, 2025
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@st3iny st3iny added bug 4. to release Ready to be released and/or waiting for tests to finish Feature: Integration An integration with another app in the ecosystem and removed 3. to review Waiting for reviews labels Jan 21, 2025
@st3iny st3iny merged commit 498c99c into main Jan 21, 2025
37 of 38 checks passed
@st3iny st3iny deleted the fix/avoid-shortkeys-in-contenteditable branch January 21, 2025 10:12
@st3iny
Copy link
Member

st3iny commented Jan 21, 2025

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jan 21, 2025
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Jan 21, 2025
Copy link

github-actions bot commented Feb 5, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Feature: Integration An integration with another app in the ecosystem feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assistant does not work when being in Calendar
3 participants