Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): Remove on mousemove listener for auto focus elements #6475

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix(NcActions): Remove on mousemove listener for auto focus elements #6475

merged 1 commit into from
Jan 31, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 30, 2025

☑️ Resolves

  1. This causes issues with the native datetime picker on Safari as the mouse move is also considered outside when hovering a picker popover that overlays other actions.
  2. In general this is very unexpected behavior, e.g. click on a text input, type something, move the mouse and keep typing. You expect to write to the same input but the focus is changed to a different while typing.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components browser: Safari labels Jan 30, 2025
@susnux susnux added this to the 8.23.0 milestone Jan 30, 2025
ShGKme

This comment was marked as resolved.

Sign in to view

@ShGKme
Copy link
Contributor

ShGKme commented Jan 30, 2025

@susnux
fix(NcActions): Remove on mousemove listener for auto focus elements
1737468 
1. This causes issues with the native datetime picker on Safari as the
   mouse move is also considered outside when hovering a picker popover
   that overlays other actions.
2. In general this is very unexpected behavior, e.g. click on a text
   input, type something, move the mouse and keep typing. You expect to
   write to the same input but the focus is changed to a different while
   typing.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/actions-on-scroll branch from 8e17f13 to 1737468 Compare January 30, 2025 15:55
@susnux susnux requested a review from ShGKme January 30, 2025 15:55
@susnux

This comment was marked as resolved.

Sign in to view
ShGKme
ShGKme approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💃

raimund-schluessler
raimund-schluessler approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

Supersedes #5014 and also closes #5991.

@raimund-schluessler raimund-schluessler mentioned this pull request Jan 31, 2025
Closed
@raimund-schluessler raimund-schluessler linked an issue Jan 31, 2025 that may be closed by this pull request
NcActionInput: Input loses focus when moving mouse #5991
Closed
@raimund-schluessler raimund-schluessler mentioned this pull request Jan 31, 2025
Closed
@raimund-schluessler raimund-schluessler merged commit 85a7c64 into master Jan 31, 2025
23 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/actions-on-scroll branch January 31, 2025 12:22
@raimund-schluessler
Copy link
Contributor

/backport to next

@backportbot backportbot bot mentioned this pull request Jan 31, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews browser: Safari bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
8.23.0
Development

Successfully merging this pull request may close these issues.

NcDateTimePickerNative: Dialog Appearance Issue in Safari NcActionInput: Input loses focus when moving mouse
3 participants
@susnux @ShGKme @raimund-schluessler