Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcEmojiPicker): adjust styles to correctly fit emojis #6465

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 27, 2025

Improving NcEmojiPicker: part 1 of 3

☑️ Resolves

  • Props says "(emoji) :per-line="8"" but it renders 7
  • Tabs icons are not centered
  • Emoji buttons have double outline on focus
  • Emoji buttons are slightly not squared
  • Paddings are from emoji-mart-vue-fast (6px) and not from Nextcloud design (8px)
  • Sections are not inline with input

Fixing styles and simplifying them

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: emoji picker Related to the emoji picker component labels Jan 27, 2025
@ShGKme ShGKme added this to the 8.23.0 milestone Jan 27, 2025
@ShGKme ShGKme requested review from susnux, szaimen and Antreesy January 27, 2025 17:27
@ShGKme ShGKme self-assigned this Jan 27, 2025
@ShGKme ShGKme mentioned this pull request Jan 27, 2025
3 tasks
raimund-schluessler

This comment was marked as resolved.

@raimund-schluessler

This comment was marked as resolved.

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All resolved now, thanks!

@ShGKme ShGKme force-pushed the fix/NcEmojiPicker--styling branch from d74cbc1 to 0c3fb1e Compare January 29, 2025 09:35
@ShGKme ShGKme merged commit 8da639f into master Jan 29, 2025
23 checks passed
@ShGKme ShGKme deleted the fix/NcEmojiPicker--styling branch January 29, 2025 09:38
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 29, 2025

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design feature: emoji picker Related to the emoji picker component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants