Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multihost: add MultihostBackupHost and BackupTopologyController #79

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

pbrezina
Copy link
Contributor

@pbrezina pbrezina commented Sep 13, 2024

MultihostBackupHost: This is a base host that provides automatic host backup and restore functionality.

BackupTopologyController: This controller provides automatic backup and restore of the topology hosts.

This is a base host that provides automatic host backup and restore
functionality.
This controller provides automatic backup and restore of the topology
hosts.
@pbrezina pbrezina changed the title multihost: add MultihostBackupHost multihost: add MultihostBackupHost and BackupTopologyController Sep 13, 2024
@justin-stephenson
Copy link
Contributor

With these changes should I remove these lines from SSSD/sssd-test-framework#119 ?

+        # Backup so we can restore to this state after each test
+        self.backup_data[ipa] = ipa.backup()
+        self.backup_data[trusted] = trusted.backup()
+        self.backup_data[client] = client.backup()

Or any other changes needed?

@pbrezina
Copy link
Contributor Author

There's SSSD/sssd-test-framework#121 (please, review it as well) that makes use of it, this is the change https://github.com/SSSD/sssd-test-framework/pull/121/files#diff-caf41b02ccb1ea1302c38f054d2709dd258847bb3228a04734a956c0ec49fab2L138-R93.

You either leave the code as is (which is perfectly fine), or remove it and call super().topology_setup() to do the backup for you. It's either or.

Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

@pbrezina pbrezina merged commit 8b03d91 into next-actions:master Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants