Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sets default make target to agent only [TEST - DO NOT MERGE] #830

Closed
wants to merge 1 commit into from

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Feb 7, 2024

To support the CodeQL C/C++ scanner autobuild functionality move the default make target to just agent so only C/C++ code it built. This is necessary because the current build env the CodeQL C/C++ scanner uses contains a too old Go compiler to build the daemon target.

Ideally the CodeQL tool/workflow could be configured to just target agent and that would be the recommended long term solution.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf0223c) 78.74% compared to head (851ff92) 78.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #830   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         189      189           
  Lines       26370    26370           
=======================================
  Hits        20766    20766           
  Misses       5604     5604           
Flag Coverage Δ
agent-for-php-7.0 77.60% <ø> (ø)
agent-for-php-7.1 77.33% <ø> (ø)
agent-for-php-7.2 77.89% <ø> (ø)
agent-for-php-7.3 77.91% <ø> (ø)
agent-for-php-7.4 77.58% <ø> (ø)
agent-for-php-8.0 77.67% <ø> (ø)
agent-for-php-8.1 77.63% <ø> (ø)
agent-for-php-8.2 77.41% <ø> (ø)
agent-for-php-8.3 77.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfulb mfulb changed the title chore: Sets default make target to agent only chore: Sets default make target to agent only [TEST - DO NOT MERGE] Feb 7, 2024
@mfulb mfulb closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants