-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(agent): reduce number of segments created #1011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1011 +/- ##
==========================================
+ Coverage 78.01% 78.02% +0.01%
==========================================
Files 197 197
Lines 27422 27418 -4
==========================================
Hits 21392 21392
+ Misses 6030 6026 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
reviewed
Jan 23, 2025
Co-authored-by: Michal Nowacki <[email protected]>
lavarou
reviewed
Jan 23, 2025
lavarou
reviewed
Jan 23, 2025
lavarou
previously approved these changes
Jan 23, 2025
Co-authored-by: Michal Nowacki <[email protected]>
lavarou
previously approved these changes
Jan 23, 2025
lavarou
approved these changes
Jan 24, 2025
lavarou
reviewed
Jan 27, 2025
mfulb
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a blanket segment_start in the "before" function that needs to be discarded in the majority of the cases, just create the segment when it is needed, add the attributes/metrics, then close the segment.
DONE:Multiverse SQS exception tests need to be updated.
DONE:Needs additional testing against backend.