Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daemon): enable go vet check on pull requests #1005

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

@lavarou lavarou self-assigned this Jan 7, 2025
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jan 7, 2025

Test Suite Status Result
Multiverse 7/7 passing
SOAK 61/62 passing

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (f26aead) to head (630dcbf).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1005   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files         196      196           
  Lines       27069    27069           
=======================================
  Hits        21280    21280           
  Misses       5789     5789           
Flag Coverage Δ
agent-for-php-7.2 78.62% <ø> (ø)
agent-for-php-7.3 78.64% <ø> (ø)
agent-for-php-7.4 78.34% <ø> (ø)
agent-for-php-8.0 78.36% <ø> (ø)
agent-for-php-8.1 78.35% <ø> (ø)
agent-for-php-8.2 77.94% <ø> (ø)
agent-for-php-8.3 77.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou marked this pull request as ready for review January 8, 2025 15:57
@lavarou lavarou merged commit 86db4f8 into dev Jan 14, 2025
57 checks passed
@lavarou lavarou deleted the chore/daemon/enable-govet branch January 14, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants