Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix CodeQL's agent scan (#1002) #1002

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Dec 20, 2024

Fix agent build scan by pinning runner to ubuntu-22.04. ubuntu-24.04, which is what ubuntu-latest has recently become, doesn't have agent's build dependency (libpcre3-dev) installed.

Agent build stopped working because build environment used by CodeQL misses
agent's build dependencies (libpcre3-dev). Disabling for now.
@lavarou lavarou requested a review from zsistla December 20, 2024 21:52
@lavarou lavarou self-assigned this Dec 20, 2024
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Dec 20, 2024

Test Suite Status Result
Multiverse 7/7 passing
SOAK 61/62 passing

zsistla
zsistla previously approved these changes Dec 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (d6db53b) to head (b4fe005).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1002   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files         196      196           
  Lines       27069    27069           
=======================================
  Hits        21280    21280           
  Misses       5789     5789           
Flag Coverage Δ
agent-for-php-7.2 78.62% <ø> (ø)
agent-for-php-7.3 78.64% <ø> (ø)
agent-for-php-7.4 78.34% <ø> (ø)
agent-for-php-8.0 78.36% <ø> (ø)
agent-for-php-8.1 78.35% <ø> (ø)
agent-for-php-8.2 77.94% <ø> (ø)
agent-for-php-8.3 77.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou changed the title ci: update CodeQL workflow to only analyze daemon ci: update CodeQL workflow to run on ubuntu-22.04 Dec 20, 2024
@lavarou lavarou changed the title ci: update CodeQL workflow to run on ubuntu-22.04 ci: fix CodeQL's agent scan (#1002) Dec 20, 2024
@lavarou lavarou merged commit 0d0f724 into dev Dec 20, 2024
56 checks passed
@lavarou lavarou deleted the ci/disable-codeql-for-agent branch December 20, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants