Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: devenv enhancements #1000

Merged
merged 3 commits into from
Dec 19, 2024
Merged

chore: devenv enhancements #1000

merged 3 commits into from
Dec 19, 2024

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Dec 19, 2024

Fix QOL aliases and allow multiple devenvs to run simultanously.

The QOL aliases need to be defined in .bashrc of the container's default user.
There is no need to expose ports to host - services within composer project
can communicate with each other without ports being forwarded to host.
Forwarding ports to host result in second instance of devenv fail to start
because the ports are already used by first instance.
There is also no need to name service containers because any interaction with
the service container can be done by service name, e.g. `docker compose exec php`.
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Dec 19, 2024

Test Suite Status Result
Multiverse 0/7 passing
SOAK 61/62 passing

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (4393980) to head (ba7419b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1000   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files         196      196           
  Lines       27047    27047           
=======================================
  Hits        21281    21281           
  Misses       5766     5766           
Flag Coverage Δ
agent-for-php-7.2 78.69% <ø> (ø)
agent-for-php-7.3 78.71% <ø> (ø)
agent-for-php-7.4 78.41% <ø> (ø)
agent-for-php-8.0 78.43% <ø> (ø)
agent-for-php-8.1 78.42% <ø> (ø)
agent-for-php-8.2 78.01% <ø> (ø)
agent-for-php-8.3 78.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Avoid "fatal: detected dubious ownership in repository at '/usr/src/myapp/'"
error when running git commands inside container with host volume mounted.
@lavarou lavarou marked this pull request as ready for review December 19, 2024 20:53
@lavarou lavarou merged commit f14a128 into dev Dec 19, 2024
55 of 56 checks passed
@lavarou lavarou deleted the chore/devenv-enhancements branch December 19, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants