Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**DRAFT** DynamoDB Relationships #2923

Draft
wants to merge 13 commits into
base: feature/invoke-lambda-instrumentation
Choose a base branch
from

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Dec 9, 2024

Adds support for building the ARM for DynamoDB, but (currently) doesn't add the cloud.resource_id attribute to the right segment. This PR depends on additional work being done in #2901 and #2924.

A notable change in this PR is that the AWS Account ID is cached per instance of the ClientConfig object, which is a property of AmazonServiceClient and is passed as a property in every pipeline invocation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (4537d5d) to head (d98fc3e).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           feature/invoke-lambda-instrumentation    #2923      +/-   ##
=========================================================================
+ Coverage                                  81.66%   81.77%   +0.11%     
=========================================================================
  Files                                        467      470       +3     
  Lines                                      29724    29873     +149     
  Branches                                    3308     3320      +12     
=========================================================================
+ Hits                                       24274    24429     +155     
+ Misses                                      4657     4653       -4     
+ Partials                                     793      791       -2     
Flag Coverage Δ
Agent 82.73% <100.00%> (+0.11%) ⬆️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ions/NewRelic.Agent.Extensions/Caching/LRUCache.cs 100.00% <100.00%> (ø)
...ns/NewRelic.Agent.Extensions/Caching/LRUHashSet.cs 100.00% <100.00%> (ø)
...Relic.Agent.Extensions/Caching/WeakReferenceKey.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants