-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
**DRAFT** DynamoDB Relationships #2923
Draft
tippmar-nr
wants to merge
13
commits into
feature/invoke-lambda-instrumentation
Choose a base branch
from
feature/dynamodb-entity-relationship
base: feature/invoke-lambda-instrumentation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
**DRAFT** DynamoDB Relationships #2923
tippmar-nr
wants to merge
13
commits into
feature/invoke-lambda-instrumentation
from
feature/dynamodb-entity-relationship
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation' into feature/dynamodb-entity-relationship
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/invoke-lambda-instrumentation #2923 +/- ##
=========================================================================
+ Coverage 81.66% 81.77% +0.11%
=========================================================================
Files 467 470 +3
Lines 29724 29873 +149
Branches 3308 3320 +12
=========================================================================
+ Hits 24274 24429 +155
+ Misses 4657 4653 -4
+ Partials 793 791 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for building the ARM for DynamoDB, but (currently) doesn't add the
cloud.resource_id
attribute to the right segment. This PR depends on additional work being done in #2901 and #2924.A notable change in this PR is that the AWS Account ID is cached per instance of the
ClientConfig
object, which is a property ofAmazonServiceClient
and is passed as a property in every pipeline invocation.