Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke lambda feature work: AWS Account ID Parsing #2911

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Dec 2, 2024

  • Adds AWS account ID parsing logic plus unit tests. Includes profiler update.
  • Tweaks to ArnBuilder to default to non-empty strings, tests updated as necessary
  • Miscellaneous refactoring in ContainerIntegrationTests project

@tippmar-nr tippmar-nr requested a review from a team as a code owner December 2, 2024 21:29
@tippmar-nr tippmar-nr marked this pull request as draft December 2, 2024 21:30
@tippmar-nr tippmar-nr changed the title **DRAFT** feat: AWS Account ID Parsing, DynamoDB relationship attribute invoke lambd feature work: AWS Account ID Parsing Dec 6, 2024
@tippmar-nr tippmar-nr changed the title invoke lambd feature work: AWS Account ID Parsing invoke lambda feature work: AWS Account ID Parsing Dec 6, 2024
@tippmar-nr tippmar-nr closed this Dec 6, 2024
@tippmar-nr tippmar-nr deleted the feature/aws-account-id-parsing branch December 6, 2024 20:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (c36d25c) to head (75a6696).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           feature/invoke-lambda-instrumentation    #2911      +/-   ##
=========================================================================
+ Coverage                                  81.44%   81.47%   +0.02%     
=========================================================================
  Files                                        466      467       +1     
  Lines                                      29692    29723      +31     
  Branches                                    3305     3309       +4     
=========================================================================
+ Hits                                       24182    24216      +34     
+ Misses                                      4715     4713       -2     
+ Partials                                     795      794       -1     
Flag Coverage Δ
Agent 82.39% <100.00%> (+0.03%) ⬆️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ons/NewRelic.Agent.Extensions/AwsSdk/ArnBuilder.cs 96.87% <100.00%> (-3.13%) ⬇️
...lic.Agent.Extensions/AwsSdk/AwsAccountIdDecoder.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants