feat: add labels from nri-winservices config as tags on UI. #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12705852369Details
💛 - Coveralls |
| entities = append(entities, r.Data.Entity) | ||
| entity := r.Data.Entity | ||
| // Add labels to Metadata | ||
| if r.Definition.Labels != nil && len(r.Definition.Labels) > 0 { |
There was a problem hiding this comment.
Is it required to check the nilness? If Labels is nil, len(r.Definition.Labels) will be 0, won't it?
| entities = append(entities, r.Data.Entity) | ||
| entity := r.Data.Entity | ||
| // Add labels to Metadata | ||
| if r.Definition.Labels != nil && len(r.Definition.Labels) > 0 { |
There was a problem hiding this comment.
Does it make sense to extract it in a short util func and add some unit tests? (Would improve coverage as well :))
But it's totally fine if we don't do this.
There was a problem hiding this comment.
Adding the unit tests for this is an excellent point ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add labels from
nri-winservicesconfig as tags on the UI.