Merge pull request #341 from neutrinoceros/depr_4.0

DEPR: expire running deprecations in prep for 4.0 rel

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - DEP: bump minimal and pinned `inifix` from 3.0.0 to 4.2.2
 - DEPR: rename print_err to print_error, deprecate old name
 - ENH: add short version `-i` for `idfx digest --input ...`
+- DEPR: expire running deprecations in prep for 4.0 rel
 
 ## [3.2.1] - 2023-09-06
 

src/idefix_cli/__main__.py

@@ -21,12 +21,7 @@
 def _get_command_paths() -> list[str]:
     dirs = [BASE_COMMAND_PATH]
 
-    if ext_dir_v1 := get_option("idefix_cli", "extension_dir"):
-        print_warning(
-            "The 'extension_dir' option is deprecated. Use 'plugins_directory' instead."
-        )
-
-    if ext_dir := get_option("idefix_cli", "plugins_directory") or ext_dir_v1:
+    if ext_dir := get_option("idefix_cli", "plugins_directory"):
         if os.path.isdir(ext_dir):
             dirs.append(ext_dir)
         else:

src/idefix_cli/_commands/run.py

@@ -181,12 +181,6 @@ def add_arguments(parser) -> None:
         help="target inifile",
     )
     tstop_group = parser.add_mutually_exclusive_group()
-    tstop_group.add_argument(
-        "--duration",
-        action="store",
-        type=float,
-        help="run for specified time (in code units) DEPRECATED",
-    )
     tstop_group.add_argument(
         "--tstop",
         action="store",
@@ -342,10 +336,7 @@ def command(
 
     if time_step is not None:
         conf["TimeIntegrator"]["first_dt"] = time_step
-    if duration is not None:
-        print_warning("The --duration argument is deprecated. Use --tstop instead.")
-        conf["TimeIntegrator"]["tstop"] = duration
-    elif tstop is not None:
+    if tstop is not None:
         conf["TimeIntegrator"]["tstop"] = tstop
 
     rebuild_mode_str: str = get_option("idfx run", "recompile") or "always"