Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move CI infrastructure to GitHub Actions #3321

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jan 28, 2025

According to https://github.com/orgs/community/discussions/70492#discussioncomment-7362186, public repositories have unlimited free minutes, with a time limit for each job of about 6 hours, which should be plenty for our use-case.

TODO:

  • add automatic upload step
  • add MPT headers (do we need this?)

@JCGoran JCGoran force-pushed the jelic/move_infra_to_gha branch from a1f0eaf to c57ea5f Compare January 28, 2025 09:21
@JCGoran JCGoran force-pushed the jelic/move_infra_to_gha branch from 9ea3830 to de7d057 Compare January 28, 2025 10:12
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.08%. Comparing base (74dcdd5) to head (5ada0ee).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3321   +/-   ##
=======================================
  Coverage   67.07%   67.08%           
=======================================
  Files         571      571           
  Lines      111055   111039   -16     
=======================================
- Hits        74488    74485    -3     
+ Misses      36567    36554   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +151 to +153
steps:
- name: Upload wheels
run: echo "TODO"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JCGoran : Just mentioning - we need to update the docs from https://nrn.readthedocs.io/en/8.2.6/install/python_wheels.html#publishing-the-wheels-on-pypi-via-azure.
Especially, having the ability to just build the release artifacts without upload has been quite helpful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, there's also the matter of "Azure drop URLs" being mentioned in other repos, so we should make sure those are modified accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants