Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to C++17 #44

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Bump to C++17 #44

merged 4 commits into from
Jul 4, 2022

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jul 1, 2022

Change required standard to C++17 and avoid using using namespace std; in a header (or anywhere else).

Closes #43.

@olupton olupton mentioned this pull request Jul 1, 2022
Merged
6 tasks
@olupton olupton marked this pull request as ready for review July 1, 2022 13:57
@olupton olupton requested a review from alkino July 1, 2022 13:57
olupton
olupton commented Jul 1, 2022
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@olupton olupton requested a review from alexsavulescu July 4, 2022 07:02
@olupton olupton merged commit 24df191 into master Jul 4, 2022
@olupton olupton deleted the olupton/c++17 branch July 4, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsavulescu alexsavulescu alexsavulescu approved these changes

@alkino alkino Awaiting requested review from alkino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using namespace std in headers.
2 participants
@olupton @alexsavulescu