New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using namespace std in headers. #43

Closed

olupton opened this issue Jul 1, 2022 · 0 comments · Fixed by #44

Collaborator

olupton commented Jul 1, 2022

In the context of neuronsimulator/nrn#1893 this line:

iv/src/include/ivstream.h

Line 12 in 84ed9e6

using namespace std;

seems to cause problems, at least on Windows: https://github.com/neuronsimulator/nrn/runs/7128845057#step:6:222.

This is bad practice anyway: SF.7: Don’t write using namespace at global scope in a header file.

This was referenced Jul 1, 2022

Require C++17 neuronsimulator/nrn#1893

Merged

Bump to C++17 #44

Merged

olupton closed this as completed in #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment