Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to build system #4

Closed
wants to merge 1 commit into from

Conversation

nmoinvaz
Copy link

@nmoinvaz nmoinvaz commented Jul 9, 2020

  • Compile each zlib variant with pigz independently.
    • Each version of pigz is tied to its own unique zlib. It allows for easily debugging a specific version of pigz tied to a certain version of zlib. Before the build script would nuke each folder when it recompiled a new variant.
  • Use mainline pigz repository.
    • Copy necessary files from pigz directory and then build.
    • We no longer have to use customized repositories with a CMake super build script.
    • These changes make this benchmark is more self-contained.
  • Added rebuild and toolchain args to compile script.

I also removed a_compile_dynamic.py. I'm not sure exactly of the purpose of it, but it seemed confusing to have two build scripts. It seems like we can accomplish the same thing with a_compile.py but just add a another command line argument.

@neurolabusc
Copy link
Owner

neurolabusc commented Jul 9, 2020

@nmoinvaz this looks great. My intention has always been to use the mainline pigz repository. However, I want to build production ready versions of pigz for each operating system. The mainline pigz does not support non-Latin characters on the Windows operating system. I would suggest we defer merging your PR until @madler has had a chance to review the pigz pull request that provides full Windows support.

Copy necessary files from pigz dir and then build.
Use mainline pigz and zlib repositories.
Added rebuild and toolchain args to compile script.
@nmoinvaz
Copy link
Author

Closing this pull request. I have since added pigz-bench to zlib-ng organization which includes some of these improvements. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants