Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stratify val_ids in stratified_train_val_test_split #72

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kirpoly
Copy link

@kirpoly kirpoly commented Feb 1, 2023

Was it intentional to just randomly take ids for validation? I guess in case of stratified split val_ids should be resemblant to the whole dataset too.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #72 (c6b9336) into develop (419e15b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
- Coverage    36.20%   36.19%   -0.02%     
===========================================
  Files           70       70              
  Lines         3190     3191       +1     
  Branches       572      572              
===========================================
  Hits          1155     1155              
- Misses        1989     1990       +1     
  Partials        46       46              
Impacted Files Coverage Δ
dpipe/split/cv.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant