-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post #1
Add post #1
Conversation
# Conflicts: # backend/src/main/java/org/example/backend/ProductController.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schaut gut aus, hab nur ein paar kleine Anmerkungen. Den .idea
Ordner solltest du zur .gitignore
hinzufügen.
Mit Sonarcloud scheint etwas noch nicht zu funktionieren. Könnt ihr da nochmal Florian fragen?
public ProductService(ProductRepository productRepository, IdService idService) { | ||
this.productRepository = productRepository; | ||
this.idService = idService; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man könne vielleicht auch nochmal den @RequiredArgsConstructor
nehmen und sich dadurch den Kontruktor sparen.
Quality Gate passed for 'neuefische_hh-java-24-2-teamproject-3-frontend'Issues Measures |
Quality Gate failed for 'neuefische_hh-java-24-2-teamproject-3-backend'Failed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Über ein Feedback freue ich mich...