Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post #1

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Add post #1

merged 9 commits into from
Jun 12, 2024

Conversation

akyil88
Copy link
Contributor

@akyil88 akyil88 commented Jun 4, 2024

Über ein Feedback freue ich mich...

Copy link

@jonashonecker jonashonecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schaut gut aus, hab nur ein paar kleine Anmerkungen. Den .idea Ordner solltest du zur .gitignore hinzufügen.

Mit Sonarcloud scheint etwas noch nicht zu funktionieren. Könnt ihr da nochmal Florian fragen?

Comment on lines +16 to +19
public ProductService(ProductRepository productRepository, IdService idService) {
this.productRepository = productRepository;
this.idService = idService;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man könne vielleicht auch nochmal den @RequiredArgsConstructornehmen und sich dadurch den Kontruktor sparen.

Copy link

sonarqubecloud bot commented Jun 8, 2024

Quality Gate Passed Quality Gate passed for 'neuefische_hh-java-24-2-teamproject-3-frontend'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jun 8, 2024

Quality Gate Failed Quality Gate failed for 'neuefische_hh-java-24-2-teamproject-3-backend'

Failed conditions
23.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@TingSHI2015 TingSHI2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@TingSHI2015 TingSHI2015 merged commit 243c663 into main Jun 12, 2024
4 of 5 checks passed
@TingSHI2015 TingSHI2015 deleted the AddPost branch June 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants