Support for use tablename acquired as regclass at previous query in PostgreSQL (prevent to "delimite" two times) #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly allowed (possible BC break)
If data contains special char, table is named with quotation marks also. Thus regclass returns name with quotes and for example operation ->table() delimites such delimited regclass name obtained from SELECT for the second time. So for example $tbl='someschema."some-table"' is in $db->table() delimited to "someschema"."""some-table""". Note: Tested for PostgreSQL only.
|
Does this feature apply only to Postgresql, or any other databases? |
dg
force-pushed
the
master
branch
2 times, most recently
from
a9e5763 to
c3cc31a
Compare
|
@dg: I tried to code it to be universal as well for other databases for reverse operation to delimite(), but don't know if any other database has some feature like regclass in postgresql. I don't like to have this feature in ResultSet if it's usable for something specific only (in this case PostgreSQL), so i decided to put it at the driver level :-) |
dg
force-pushed
the
master
branch
2 times, most recently
from
e91b234 to
953502b
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
52d72e1 to
fd0d57c
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
f06c30e to
1b974d3
Compare
dg
force-pushed
the
master
branch
26 times, most recently
from
a329d1b to
9f82d9d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
1769a67 to
b02f117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If data contains special char, table is named with quotation marks also. Thus regclass returns name with quotes and for example operation ->table() delimites such delimited regclass name obtained from SELECT for the second time. So for example $tbl='someschema."some-table"' is in $db->table() delimited to "someschema"."""some-table""".
Note: Tested for PostgreSQL only.