-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LinkGenerator: allow semicolon destination prefix #256
Open
dakujem
wants to merge
25
commits into
nette:master
Choose a base branch
from
dakujem:feat/trim-semicolon-prefixed-links-in-link-generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LinkGenerator: allow semicolon destination prefix #256
dakujem
wants to merge
25
commits into
nette:master
from
dakujem:feat/trim-semicolon-prefixed-links-in-link-generator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e23d6da
to
22d5246
Compare
4d7947a
to
82ad558
Compare
@dg I'd be grateful if this was merged & released promptly. It would be awesome. I see praparations for next release. This should be fully compatible. |
4aeacfd
to
06a6513
Compare
3b21865
to
548c1db
Compare
18efdae
to
3f51018
Compare
Should I rebase this? Any plan to fix the issue? |
82ad558
to
b293b75
Compare
You should update your test config - PHP 7.1 is no longer your target. |
b293b75
to
6f03449
Compare
ef333e6
to
9d529b4
Compare
426e735
to
c19ebdc
Compare
2b9da37
to
30d90f4
Compare
bf86204
to
c91f90a
Compare
57bd587
to
e908315
Compare
c5ecbda
to
ecb200c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing semicolon-prefixed destinations to
LinkGenerator::link
calls:--
closes #255