DHLGW-733: update required phpstan version and fix inspection issues

netresearch · Jan 16, 2020 · 2f69a46 · 2f69a46
1 parent f603b8c
commit 2f69a46
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/composer.json b/composer.json
@@ -24,7 +24,7 @@
     "require-dev": {
         "ext-simplexml": "*",
         "phpunit/phpunit": "^6.0.0",
-        "phpstan/phpstan": "^0.11.4",
+        "phpstan/phpstan": "^0.9.0",
         "squizlabs/php_codesniffer": "^3.4"
     },
     "autoload": {

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,4 @@
 includes:
-  - vendor/phpstan/phpstan/conf/bleedingEdge.neon
 parameters:
   ignoreErrors:
     - "#Access to an undefined property SoapFault*#"
diff --git a/src/Model/DeleteShipment/ResponseType/DeletionState.php b/src/Model/DeleteShipment/ResponseType/DeletionState.php
@@ -39,7 +39,7 @@ public function getShipmentNumber(): string
     }
 
     /**
-     * @return Statusinformation
+     * @return StatusInformation
      */
     public function getStatus(): StatusInformation
     {

diff --git a/src/Soap/ClientDecorator/LoggerDecorator.php b/src/Soap/ClientDecorator/LoggerDecorator.php
@@ -66,6 +66,8 @@ public function __construct(AbstractClient $client, \SoapClient $soapClient, Log
      */
     private function logCommunication(\Closure $performRequest)
     {
+        $logLevel = LogLevel::INFO;
+
         try {
             /** @var CreateShipmentOrderResponse|DeleteShipmentOrderResponse $response */
             $response = $performRequest();
@@ -80,8 +82,6 @@ private function logCommunication(\Closure $performRequest)
             } elseif ($response->getStatus()->getStatusText() === 'Weak validation error occured.') {
                 // weak validation errors contained in response.
                 $logLevel = LogLevel::WARNING;
-            } else {
-                $logLevel = LogLevel::INFO;
             }
 
             return $response;
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,7 +39,7 @@ public function getShipmentNumber(): string @@
         }
         /**
-         * @return Statusinformation
+         * @return StatusInformation
          */
         public function getStatus(): StatusInformation
         {
@@ Expand Down @@