Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure Lighthouse plugin upgrade is done even if site is pinned to earlier major #1302

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Jan 30, 2024

No description provided.

@Skn0tt Skn0tt requested a review from a team as a code owner January 30, 2024 16:32
@Skn0tt Skn0tt self-assigned this Jan 30, 2024
Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for netlify-plugins ready!

Name Link
🔨 Latest commit 34ceee8
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugins/deploys/65b924ac89291b0009ac1d4c
😎 Deploy Preview https://deploy-preview-1302--netlify-plugins.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Skn0tt Skn0tt changed the title Ensure Lighthouse plugin upgrade is done even if site is pinned to earlier major fix: Ensure Lighthouse plugin upgrade is done even if site is pinned to earlier major Jan 30, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not a lot of context to go by, but I'm assuming you've tested that the upgrade is safe.

@@ -495,7 +495,8 @@
"version": "6.0.0",
"compatibility": [
{
"version": "6.0.0"
"version": "6.0.0",
"overridePinnedVersion": ">=5.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the formatting is off here.

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Jan 31, 2024

There's not a lot of context to go by, but I'm assuming you've tested that the upgrade is safe.

I did! The only change is that we're changing the node engine compatibility from >=14.15 <20 to >= 18.14. And since we're currently doing the upgrade from 18 to 20 for the system version (the version used to run the plugins from plugin.json), both are within the new compatibility.

@Skn0tt Skn0tt merged commit 078e222 into main Jan 31, 2024
7 of 8 checks passed
@Skn0tt Skn0tt deleted the Skn0tt-patch-1 branch January 31, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants