Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release device-discovery 🚚 #56

Merged
merged 2 commits into from
Jan 17, 2025
Merged

release device-discovery 🚚 #56

merged 2 commits into from
Jan 17, 2025

Conversation

leoparente
Copy link
Contributor

This pull request includes several changes to the device-discovery package, primarily focusing on renaming "Orb Discovery" to "Device Discovery" and updating test cases to reflect changes in interface handling.

Fix bug in interface IP translation:

Renaming "Orb Discovery" to "Device Discovery":

Updates to test cases:

  • device-discovery/tests/test_translate.py:
    • Added a new interface to the sample device info.
    • Included additional interface details in the sample interface info.
    • Updated sample interface IPs to reflect the new interface.
    • Enhanced test cases to verify the correct handling of the new interface and its IPs. [1] [2]

@leoparente leoparente self-assigned this Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
device_discovery
   discovery.py35294%91–94
   main.py32294%90, 96
   server.py68494%33–35, 128, 131
   version.py7186%14
device_discovery/policy
   manager.py41295%36–37
   runner.py66198%49
TOTAL4011297% 

Tests Skipped Failures Errors Time
49 0 💤 0 ❌ 0 🔥 6.359s ⏱️

Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@leoparente leoparente merged commit b515c2b into release Jan 17, 2025
7 checks passed
Copy link

🎉 This PR is included in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 0.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants