Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more defaults support for network and device discovery #44

Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat: add more defaults support for network and device discovery #44

merged 1 commit into from
Dec 27, 2024

Conversation

leoparente
Copy link
Contributor

No description provided.

@leoparente leoparente self-assigned this Dec 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
device_discovery
   discovery.py35294%91–94
   main.py32294%90, 96
   server.py68494%33–35, 128, 131
   version.py7186%14
device_discovery/policy
   manager.py41295%36–37
   runner.py64198%49
TOTAL3991297% 

Tests Skipped Failures Errors Time
49 0 💤 0 ❌ 0 🔥 5.839s ⏱️

@github-actions GitHub Actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
device_discovery
   discovery.py35294%91–94
   main.py32294%90, 96
   server.py68494%33–35, 128, 131
   version.py7186%14
device_discovery/policy
   manager.py41295%36–37
   runner.py64198%49
TOTAL3991297% 

Tests Skipped Failures Errors Time
49 0 💤 0 ❌ 0 🔥 2.707s ⏱️

@github-actions GitHub Actions
Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.02s github.com/netboxlabs/orb-discovery/network-discovery/config 100.0% 8 0 0
🟢 PASS 4.04s github.com/netboxlabs/orb-discovery/network-discovery/policy 85.2% 10 0 0
🟢 PASS 1.02s github.com/netboxlabs/orb-discovery/network-discovery/server 85.5% 8 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-discovery/network-discovery/version 100.0% 1 0 0

Total coverage: 86.8%

mfiedorowicz
mfiedorowicz approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoparente leoparente merged commit 81688cd into develop Dec 27, 2024
9 checks passed
@leoparente leoparente deleted the feat/OBS-625-expand-defaults branch December 27, 2024 18:45
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@ltucker ltucker Awaiting requested review from ltucker

Assignees

@leoparente leoparente

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoparente @mfiedorowicz