Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configure diode producer_app_name prefix #35

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

leoparente
Copy link
Contributor

@leoparente leoparente commented Dec 13, 2024

also fix issues:

  • device-discovery: not integer port number
  • device-discovery: not applying resolved api_key env variable

@leoparente leoparente self-assigned this Dec 13, 2024
Copy link

linear bot commented Dec 13, 2024

OBS-596 [orb-discovery] Add producer_app_name prefix on discovery backends

Allow through command line to add prefix producer_app_name

Copy link

github-actions bot commented Dec 13, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
device_discovery
   discovery.py35294%91–94
   main.py32294%90, 96
   server.py68494%33–35, 128, 131
   version.py7186%14
device_discovery/policy
   manager.py41295%36–37
   runner.py64198%49
TOTAL3581297% 

Tests Skipped Failures Errors Time
49 0 💤 0 ❌ 0 🔥 3.304s ⏱️

Copy link

github-actions bot commented Dec 13, 2024

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.02s github.com/netboxlabs/orb-discovery/network-discovery/config 100.0% 8 0 0
🟢 PASS 4.14s github.com/netboxlabs/orb-discovery/network-discovery/policy 84.2% 10 0 0
🟢 PASS 1.04s github.com/netboxlabs/orb-discovery/network-discovery/server 85.5% 8 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-discovery/network-discovery/version 100.0% 1 0 0

Total coverage: 86.3%

Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@leoparente leoparente merged commit 65822a8 into develop Dec 13, 2024
5 checks passed
@leoparente leoparente deleted the feat/OBS-596-prefix-producer-app-name branch December 13, 2024 15:46
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants