Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement orb worker backend #49

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Conversation

leoparente
Copy link
Contributor

This pull request introduces a new backend called worker to the orb-agent project. The changes include updates to documentation, configuration files, and the implementation of the worker backend itself. Below are the most important changes:

Documentation Updates:

  • README.md: Added worker backend to the list of supported backends and updated the configuration example to include worker. [1] [2]
  • docs/backends/worker.md: Created a new documentation file for the worker backend, detailing its configuration and policies.

Code Implementation:

Configuration and Integration:

  • cmd/main.go: Registered the worker backend and its specific variables in the main application.
  • agent/docker/Dockerfile: Updated the Dockerfile to install the netboxlabs-orb-worker package.

@leoparente leoparente self-assigned this Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.03s github.com/netboxlabs/orb-agent/agent 0.0% 1 0 0
🟢 PASS 0.19s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 0.0% 0 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/backend/otel 9.7% 2 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/worker 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/config 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policies 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policyMgr 0.0% 0 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 2.1%

agent/backend/worker/worker.go Dismissed Show dismissed Hide dismissed
@leoparente leoparente requested review from rboucher-me, ltucker and mfiedorowicz and removed request for rboucher-me and ltucker January 17, 2025 16:37
@leoparente leoparente marked this pull request as ready for review January 17, 2025 16:37
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor log suggestion

agent/backend/worker/worker.go Outdated Show resolved Hide resolved
Co-authored-by: Michal Fiedorowicz <[email protected]>
Copy link
Contributor

@rboucher-me rboucher-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!

@leoparente leoparente merged commit 52f6a62 into develop Jan 21, 2025
6 checks passed
@leoparente leoparente deleted the feat/OBS-688-worker-backend branch January 21, 2025 13:56
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants