Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #56

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Fix integration tests #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd54852
Isolate failing test for debugging
jstudler Sep 9, 2024
452073c
Isolate failing test for debugging
jstudler Sep 9, 2024
fb3585a
Isolate failing test for debugging
jstudler Sep 9, 2024
29164ad
Move from Expect to Eventually for the faulty test line
jstudler Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controller/ipaddress_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ var _ = Describe("IpAddress Controller", Ordered, func() {

// Create our CR
By("Creating IpAddress CR")
Expect(k8sClient.Create(ctx, cr)).Should(Succeed())
Eventually(k8sClient.Create(ctx, cr), timeout, interval).Should(Succeed())

// check that reconcile loop did run a least once by checking that conditions are set
createdCR := &netboxv1.IpAddress{}
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/ipaddressclaim_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ var _ = Describe("IpAddressClaim Controller", Ordered, func() {

// Create our CR
By("Creating IpAddressClaim CR")
Expect(k8sClient.Create(ctx, cr)).Should(Succeed())
Eventually(k8sClient.Create(ctx, cr), timeout, interval).Should(Succeed())

// check that ip address claim CR was created
createdCR := &netboxv1.IpAddressClaim{}
Expand Down