Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add terminus v11 migration guide #3187

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

BrunnerLivio
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

Description

Documentation update for Terminus v11, related nestjs/terminus#2570, nestjs/terminus#2571

private readonly healthIndicatorService: HealthIndicatorService,
) {}

private getBadboys() { // ... }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private getBadboys() { // ... }
private getBadboys() {
// ...
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to save some space :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to save some space :)

😄, Alternatively, it can be done like this:

private getBadboys() { ... }

@kamilmysliwiec kamilmysliwiec merged commit d11be73 into nestjs:master Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants