-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loading functions, fix various issues and complete pipeline #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athrado
changed the title
19 epc from s3
Updates to loading functions and various fixes
Mar 20, 2023
athrado
changed the title
Updates to loading functions and various fixes
Update loading functions, fox various issues and complete pipeline
Mar 20, 2023
athrado
changed the title
Update loading functions, fox various issues and complete pipeline
Update loading functions, fix various issues and complete pipeline
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewers,
Thanks you for reviewing and testing this branch of asf-core-data. This PR contains adjustments to the code for many different issues and challenges with the code. The most important are:
This PR will resolve the following issues: #19, #24, #25, #26, #28, #29 (will be picked up in new issue again), #30, #32, #33, #34, #35, #36, #38, #39, #40.
It would be very much appreciated if the following scripts could be reviewed:
Suggestions for @ch-williamson:
Suggestions for @sofiapinto:
generate_and_save_mcs(verbose=True)
.Easy wins :)
Note: All MCS scripts are fully reviewed when merging with Chris' branch. My changes to those scripts were mainly path adjustments anyways. The base_config.py file will also be optimised after all the merging.
As for running the code, I would recommend running the two notebooks:
generate_and_save_mcs(verbose=True)
.Checklist:
notebooks/
pre-commit
and addressed any issues not automatically fixeddev
README
soutput/reports/