Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor MCS issues and checks #51

Open
athrado opened this issue Mar 8, 2023 · 0 comments
Open

Minor MCS issues and checks #51

athrado opened this issue Mar 8, 2023 · 0 comments

Comments

@athrado
Copy link
Contributor

athrado commented Mar 8, 2023

  • data_joining.join_mcs_epc_data.join_mcs_epc_data(): output is only saved when verbose, is that the intention?
  • config/base_config.py: we have to double check the paths
  • pipeline/mcs/generate_mcs_data.py (around line 225): file_prefix = keyword_to_path_dict[epc_version].split("{")[0] is that correct?
@athrado athrado changed the title Minor MCS issues Minor MCS issues and checks Mar 8, 2023
@athrado athrado mentioned this issue Mar 8, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@athrado