102 share action charts #103
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhrhadley
commented
Jan 6, 2025
| how="left", | ||
| ) | ||
|
|
||
| ### FLAG: This step seems wrong to me - surely it should just be coefficient * 3 rather than coefficient * (npm_score - 3)?? |
There was a problem hiding this comment.
Should have already deleted this comment (moment of confusion from me while working) - it should be coefficient * (npm_score - 3) as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey Darren, apologies this is such a large PR - I branched off another branch that hasn't been merged yet so a lot of files here you don't need to look at. Files involved in making the charts are:
ahl_targets/pipeline/2024_update/simulation_npm.py: runs the NPM simulation modelahl_targets/pipeline/2024_update/simulation_hfss.py: runs the HFSS simulation modelahl_targets/analysis/share_action_plots/share_action_plots.py: creates the chartsInput data for flourish are
dfandhfss_dfin the last python script (on S3 here: s3://ahl-private-data/in_home/processed/targets/share_action_custom_plots/). x axis isnew_converted_npmand y axis can be created from thekg_w_newfield (this is the total weight of product sold (kg) / sum(total weight of products sold). Depending on how you want to plot the graph, you could also use thetotal_kgfield on the y-axis.The simulation models aren't super well documented so please let me know if you have questions.
Fixes #102